Fix port range splitting crash due to u16 overflow#1918
Open
fristonio wants to merge 1 commit into
Open
Conversation
This commit fixes a crash in proxy during port range splitting caused by u16 overflow when inserting a port range with `end_port` U16_MAX that overlaps with existing port range end port. The crash happens due to port range splitting algorithm incorrectly attempting to insert a overlapping port range that should already be covered by an existing port range. This commit fixes the issue by skipping port range insert when the new range is already covered by iterator at the end. Fixes cilium/cilium#45811 Signed-off-by: Deepesh Pathak <deepeshpathak09@gmail.com>
nezdolik
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message for details.
Fixes cilium/cilium#45811